EasyCorp/EasyAdminBundle
+
( -3)
-
It broke because the HTML structure was different when creating items in an empty collection VS a non-empty one (sorry for not testing this case). This has been fixed by adding the missing `<div>` with the required `[data-empty-collection]` attribute.
Sorry, I overlooked this until now. Without this message - if we forget to create a CRUD controller - we get an error message which does not help:
Sorry, this was wrong from me!
Sorry, this was wrong
The changing assets links creates a problem for us. I know it can be solved with WebpackEncoreBundle Twig functions ... but I don't want to increase the friction of using EasyAdmin by requiring other bundles installations and configuration (besides the basic and common Symfony bundles). Sorry!
Oops, I introduced a bug, sorry...
Oops, I introduced a bug, sorry...
@wouterj sorry to bother you ... but this code calls to `$route->getRouteCollection();` and if I remember it right, you insisted that the method should not be used. In fact, Symfony Docs say exactly that: https://symfony.com/doc/current/routing.html#checking-if-a-route-exists
It may seem a small difference from the screenshots, but it's pretty bad when you have many fields mixed together in the same form, sorry for that.
This finishes the work done by @alterphp on #2538. I'm sorry but I couldn't send my commits to your pull request, so I've created a new pull request based on yours. I've maintained your original commits so you'll get full credit for your work.
Sorry I'm not express and I was forced to create two pull request :|
@weaverryan @ifdattic I'm sorry I didn't add this earlier! Cheers.
Some people commented this problem too in some issue comment, but I lost the reference to it. I'm sorry.
@ogizanagi sorry for being picky. Your PR is completely correct, but in the original PR I used the ternary operator to simplify code (which of course was wrong). Looking at your solution, I think it's better to use two `if` instead of chaining ternary operators.
I'm really sorry for having merged a previous pull request that contained bugs. I wanted to merge that bugfix soon and I couldn't wait for Travis to finish :(
@ogizanagi appears as the sole author of `EasyAdminExtension` and `EasyAdminFormType` Thanks! @Pierstoval unfortunately for you, authorship is not included in the tests classes, which is where you created the classes. I'm sorry about this.
|