bazelbuild/bazel
+
( 6)
-
- narrow the scope of various try blocks (sorry, messy diff).
Sorry for the messy diff. A number of things have crossed the boundary
This is a breaking API change for Copybara. Sorry.
Sorry, Ingo.
sorry) asserts that we still do zero stats for an empty output and that
Another breaking API change for Copybara. Sorry. One day this will all be over.
This is inevitably a breaking API change (sorry copybara).
(Sorry, forgot about this utility.)
in the same Bazel binary---but better safe than sorry.)
test suite expansion, and they are not consistent. Sorry about that.
I should have written this comment more precisely. I am sorry I didn't. I vaguely recall some issues where the PackageFactory usage would do some scan of all the skylark classes and do some mutation to global state (this wouldn't normally be a problem since for blaze/bazel, there's one PackageFactory instance created per blaze/bazel server, and it's created at the beginning of the server).
In my first attempt, I was doing too much - I was also trying to save the CPU-costs in the env.update call (dispatches to the just-created lexical frame, and calls LexicalFrame#put, which does an unnecessary mutability sanity check, etc) and in doing so completely missed the above bugs. Sorry.
The previous tests (internal-only, sorry) were checking for the total
This is just a minor fix because when this call happens, the other thread is not running yet, but better be safe than sorry.
safe than sorry.
Sorry, there was no good way to do this piecemeal.
|