facebook/folly
+
( -1)
-
This dynamic casts shit all over the place and is less typesafe then the previous iteration, but I think with some carefully placed static_asserts, could be just as safe (in the case where you don't do any modification, anyway)
_build/deps/folly/folly/experimental/symbolizer/Dwarf.cpp:49:70: sorry, unimplemented: non-trivial designated initializers not supported
Sorry about the churn (& time spent on this), but this backs out the change in D20671620.
And disable it globally for gcc < 5 (sorry, but not sorry). The gcc < 5 implementation is far too restrictive.
(Sorry for missing this in review).
Sorry, forgot to add portability/Memory.cpp
Summary: sorry
sorry this was bothering me
Summary: Sorry, forgot to include tests for the other side of the equation.
Sorry, must make diff if it's a new commit.
|