ptmt/react-native-macos
+
( -7)
-
I am sorry, sumkit. You are still awesome. :)
I had fixed this locally but hadn't updated the original pull request, sorry. This commit is working for us in production.
This was a lie, background color is not supported (yet). Sorry for the false hopes :)
I considered updating RNTester but I couldn't for the life of me figure out how to get it to compile on my machine, sorry ;-) I can confirm my change works when applied directly in the node_modules of an existing RN project.
This should probably be two separate diffs, sorry. It takes forever to test these things on fb4a though.
I also looked through listed issues to try and find a previous attempt to fix this error but couldn't find any references, sorry if I missed anything.
(Sorry for inconvenience, could've been removed by mistake!)
Unbreak compiling error - sorry
Sorry, don't have time to write tests. 😢
Sorry for trivial one, but I feel no need to share '.iml' in a project, so it should be ignored.
I'm also adding Nullable annotation in a bunch of places. To lazy to send it as a separate change - sorry.
Summary:This adds missing check and promise reject for failing network requests. Which was missing in the fetch.js update. Sorry for the trouble.
> Sorry to chime in super late but I actually think that this is harmful to support .jsx extension. We now live in a world where we have many transforms for es6, flow, jsx... Why would we add .jsx but not .flow or .es6. Supporting more extensions is only going to fragment tools even more.
Actually submitting the right number. Sorry for the spam :(
|