symfony/framework-bundle
+
( 26)
-
@frosas relying on X.Y.* is painful because you always need to wait until someone updates the constraint to get the new version. Of course using ~1.3 like in this PR means if I fuck up and break BC people will update to it, but that's a less likely occurrence than the alternative I think, so I would rather not use X.Y.*
Sorry for the inconvenience :)
@fabpot I know I keep insisting on this one and I am sorry for that but I think this should be considered as a bug fix (see the PR header for details) and should be merged in 2.2. I think the Symfony core should be exemplary as it is used by many developers as a template when creating their own bundle. *This PR is no more a WIP and can be merged right now*.
YES YES YES :+1:. Sorry for my enthusiasm, but I already copy pasted the PropertyPath class to some of my libraries to avoid linking to the whole Form component. I thus will be glad to officially use this component into my libraries via composer.
@frosas sorry I didn't get you still had the problem. I tagged a 2.1.7 of monologbundle which hopefully fixes your issue.
@bschussek Yes I mean this case =) Sorry for not being explicit, I need some coffee I think =)
ah sorry, I looked at the patch too fast. Only the interface is moved
Wasn't aware that github omits the trailing white line, sorry.
_Edit: Sorry, couldn't resist adding a private helper class again!_
Sorry for the inconvenience.
Sorry, I didn't think that we would be an issue since the Bundle "Best Practices" states to not include other bundles as dependencies.
damn sorry i have accidentally close the pull request ;(
added missing change from previous commit (sorry :()
|