symfony/symfony
+
(
7)
-
@frosas relying on X.Y.* is painful because you always need to wait until someone updates the constraint to get the new version. Of course using ~1.3 like in this PR means if I fuck up and break BC people will update to it, but that's a less likely occurrence than the alternative I think, so I would rather not use X.Y.*
Both names are extremely general and their PHPdocs contains pure no-shit-sherlock-descriptions :squirrel: (like "The key."). This made me and @iltar think it's just an inconsistency and they have the same meaning.
(sorry for pinging reviewers, switching branch trigger that)
I left a comment that has nothing to do with this test. I'm sorry.
Replace the #48253 (I failed to target new branch with Git, sorry...)
Sorry for doing two things in a single PR, but it felt too small to split.
In all cases, the generation itself is trivial using inheritance (sorry `final` classes.) For example, in order to turn a `Foo` class into a lazy ghost object, one just needs to do:
Sorry but I did not catch everything in the first one.
`@chalasr` `@wouterj` sorry for the long description but in the hope of getting this included in 5.3.0, if you can provide guidance I will happily work on this further tomorrow to try and wrap it up ASAP.
Sorry screwed up my previous branch while rebasing and amending the author name of the commits.
Same as #40911, different class. Sorry, I missed the seconds abstract class. 🙈
Sorry for this PR without test, But it's really to hard to reproduce the issue :(
🤷🏻♂️ This pull-request is a copy of [this pull-request ](https://github.com/symfony/symfony/pull/39927) that I've created some weeks ago. On the original PR, I just needed to rebase on 5.x to pass the tests (fabbot etc.) but the rebase I've tried runs in a loop of conflicts and I'm stuck. I've never experienced this before... SORRY.
Sorry, bug I make a typo in file README.md. Please accept this pr and fix this problem.
I missed this file. Sorry :(
Sorry for such small PR. I found this when I was parsing the yaml after running `bin/console config:dump-reference TwigBundle`
Fixup of #39293. This change should make the tests pass without Xdebug. Sorry for the messup. 🙈
If this PR is not relevant please close and sorry for inconvenience.
| Branch? | 5.2 (hopefully? sorry to keep pushing the barrier here)
I'm sorry for catching this soo late in the release cycle. There is a BC break involved here, but it's (a) very unlikely to impact application code and (b) in an experimental class.
Hm.. Im sorry for the many PRs.
Sorry for making a few BC breaks.
Sorry for a small PR. When working with https://github.com/symfony/symfony-docs/pull/14404, I found a typo, then another one.. When I found 4 of them I decided to make a PR.
Sorry for the long description, but I think that sometimes it is necessary for too complex issues and big changes. Besides, now you know a little more about what these changes is about.
Move the polyfill method introduced in #37960 in the `Assert` trait. Sorry I noticed this trait later.
This fixes a test bug introduced by #37844 Next time, I'll open a PR in draft state before I'm sure I didn't break any tests, sorry!
Fixup of #37778. My code was apparently not php5-friendly. Sorry for that. 😓
Found while testing https://github.com/scheb/2fa/pull/8, sorry for not spotting it before the stable release :disappointed:
This simple change should fix, I'm sorry if I'm wrong.
**Provider doc:** (🇫🇷 sorry)
I forgot about it in the original PR (#35744) - sorry for the extra work.
We are sorry that this issue slipt through our QA pipeline. The linked issue already showed that the issue is now fixed by just doing a `composer update` but it is not very convenient to leave this known issue in symfony.
Sorry, I'm late on https://github.com/symfony/symfony/pull/33613 and https://github.com/symfony/symfony/pull/33614 but I realized 3 minor visual issues:
Sorry for the noise! This is hopefully the last pull request related to the Welcome Page design tweaks. This one tweaks some margins, makes it look better on ultra-wide screens and prevents some unwanted horizontal/vertical scrollbars on some browsers.
After #33459, the composer suggestions for the validator component are a bit misleading. Sorry for having missed that in my PR.
I am sorry but I detected a few more cases.
I am sorry but I detected a few more cases.
Tests I missed from #31355 - sorry about that!
Let's make love (& good code) not war. Sorry for not submitting it at least yesterday, but hopefully you will accept it, and we will be able to merge today. This will allow us to add different addons on other special ocasions.
We saw VarDumper errors in armhf, but they are hard to reproduce interactively. In the issue report, it was suggested to replace %d with %i, and that's what I did in this branch. I'm sorry I can't give you confidence that this fixes the issue, and I'm just filing this PR because it was suggested and I'm trying to be helpful. I'm hoping there is CI here that can verify it.
> Something went wrong when merging this PR. @gmponos Can you resubmit it again? Sorry for the trouble.
Apparently I talked about it in the previous PR, but forgot to actually push the change. Sorry about that! 😞
Sorry again, just forgot to actually update the last PR.
replaces #26180, which was wrongly sent (and merged) for `master` branch instead of `3.4`, sorry for mistake.
Sorry for my bad english, I'm French and this is my first bug report :)
Unfortunately I didn't test https://github.com/symfony/symfony/pull/24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.
Sorry for that :)
| Bug fix? | ~~~~yes~~~ no (sorry)
Sorry for opening this so lately... I just realized that we could get rid of `Yaml::PARSE_KEYS_AS_STRINGS` just by recommending using quotes...
(And sorry for the noise around this feature, I want to polish it for 3.4)
The documentation states that we dispatch events `workflow.announce` and `workflow.[name].announce`. It was me who wrongly added it to the docs... sorry about that.
Sorry for the inconvenience :)
This is a second fix for the issue discussed in #20411. My first PR (#21279) didn't fix the bug in all cases, sorry.
Me (and all reviewers ;) ) totally miss this class. It has never been used and there are no reason to use it anyway. It's just a relic from the designing of the Component. Sorry.
Reviewing the diff on GitHub, I realized I've missed some typos in a new test of #21877. Sorry!
I've messed up the return value of parseDefaults under certain conditions in #21342. Here is the fix... Sorry about that.
@klausi could you please validate this patch? Is it an improvement over yours? (sorry I don't have the proper use case to test.)
Sorry for being late on this original issue! It looked good to me at first :).
In PR https://github.com/symfony/symfony/pull/20199 I made changes after review that broke the use of env variables, sorry about that - should have checked it a bit more before making the changes.
Sorry.. almost there :) fixes 1 more false positive in `ObjectNormalizerTest`.
Not sure if bug or feature. The bug label is probably not apropriate, sorry. But I guess it should be merged to all versions.
This a follow up of #17545 as i introduce bad methods name in the traits sorry :/
PS: sorry to keep you waiting, @webmozart . When merging both commit don't forget to add the `@deprecated` annotation, and that `SingleAssociationToIntIdEntity.php` is duplicated.
Overlaps #14017 (might replace or follow it) . Sorry if it is considered as a duplicate, but the debate has evolved, and I think the arguments ordering isn't the best nor single way to improve this command usage anymore.
I should be done with cs fixes to the 2.3 branch now. Sorry I missed these in my last pull.
Sorry for the noise, but everytime I open this class, I wonder what is `$exception`.
sorry about the previous PR now closed, forgot Gush had branched off of master and not 2.3
**This is exact the same commit as it was in #9585, which was not merged due to my fault. Sorry for the noise.**
**I've sent it against wrong branch. It should be merged in 2.3. Sorry.**
The previous translation was not entirely correct, sorry!
Sorry for the multiple PRs
@fabpot sorry for the running gag
but since I am struggling to squash all the commits I better create a new one. Sorry for the inconveniences, :)
Im sorry but have the same...
sorry: https://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+
Sorry for neglecting the unit tests, they've been updated (2 matching new common date formats, 1 uncommon date format, and changing the existing bad-date check to be more realistically bad.)
hmm sorry, I missed the fact that you are changing the locale in the Request again, which will set the intl one
@fabpot I know I keep insisting on this one and I am sorry for that but I think this should be considered as a bug fix (see the PR header for details) and should be merged in 2.2. I think the Symfony core should be exemplary as it is used by many developers as a template when creating their own bundle. *This PR is no more a WIP and can be merged right now*.
oops, sorry.
YES YES YES :+1:. Sorry for my enthusiasm, but I already copy pasted the PropertyPath class to some of my libraries to avoid linking to the whole Form component. I thus will be glad to officially use this component into my libraries via composer.
So sorry.
@frosas sorry I didn't get you still had the problem. I tagged a 2.1.7 of monologbundle which hopefully fixes your issue.
Sorry, but I don't understand the use case.
Sorry I was not aware of the trigger_error() agreement, absolutely +1 on it.
Sorry, I add to clone the symfony repo with github and did small editing using pspad, I forgot to setup charset and line feed...
sorry but i dont understand what you suggest. more over i dont see the problem. its already possible to seriously break stuff with compiler passes which cannot be easily enabled/disabled. this is just convenience. if it doesnt work because of some obscure combo then simply dont use it for the app since it needs to be explicitly enabled in the kernel.
The example, sorry :smiley:
@fabpot Sorry, I had a little copy/paste mistake here #6205
sorry for being pushy about this one, but we need to know if this change is ok or not, if we need to improve something. if there is some problem we did not think of, we have to find different solutions for the cmf/drupal matchers.
Sorry for the hassle
sorry, it's bug in VichUploaderBundle
Sorry please check https://github.com/Seldaek/symfony/commit/376dd93c569362a162bd2e79c7eea115ac5e355e instead, I missed a few tests in the RequestTest class.
Sorry I've been sitting on this for so long. I haven't had time to figure out how to get rid of the merge commit, as @stof requested. That's the only outstanding issue here, as far as I know.
@stealth35: Sorry. I have to ask again.
Yeah sorry `MimeTypeExtensionGuesser` is for getting an extension with the Mime, forget about this, i'll take care aboute all MIME intégration later
ping @fabpot sorry to keep pushing this, but any chance you could take a look at this?
Sorry, I forgot `[Finder]` tag in 3 commits message... is it fixable?
Ouch, I'm really sorry, I was in the wrong tmux window when started tests :/
@fabpot sorry for the mess, I should go to bed :/
hmm, sorry. It is a browser cache issue. It seems like your server was sending cache headers for the assets, and as I already looked at the demo previously (for your DoctrineBundle PR), it kept the old CSS
Sorry. I misunderstand your PR.
@stof Sorry, i fixed that.
This was pretty hard to figure out. I could fix 4 bugs and refactor the code to safe 2 variables and several assignments. Sorry for doing this in one commit, but they were highly interdependent.
@Burgov Ah sorry, I got confused and thought this was another dupe
@fabpot Actually, sorry, this node is not in 2.0 it was introduced in 2.1 last month.
Done! Sorry for the delay
@fabpot: Sorry, not sure how: Under 2.1.0 or in a new section? As the first or last entry of the list?
Shoot, sorry about that.
Sorry for the mess, cleaning it
Sorry, I'm cannot observe all changes for form component in 2.1, so I have a question:
I am sorry, of wasting your time... totally confused about using git. I feel a little bit squashed :-) of a the possible actions.
Sorry, the failing test is the following:
I have no idea how to do it using web interface. I'm not familiar with git (prefer hg). Sorry.
@vicb Sorry, for the email flood :)
Sorry for that..
@stof: I'm sorry. It should be working now.
Regarding adding a tab for phpinfo, sure it would be useful BUT if the reasoning is that some people leave a publicly available phpinfo script therefore just include it then I would not include it. There are many more useful requirements of the toolbar rather than to insulate intro to web issues. That's like saying don't include the toolbar because someone may build an application that makes the toolbar available publicly (which will happen). I've seen too many projects in my years having no clue of versioning tools that must have been built on the server, live, with filenames like indexv1.php, indexv2.php, indexTryAgain.php, db credentials in the clear, and just hoping to find a point where it works enough. And yes, I've found those scripts were publicly available and still around years after they were created; security holes and all! I'm preaching to the choir here. You'll never stop stupid. All we can do is educate by any means we have and share our knowledge with one another. Aside from that devils advocate reasoning, I would include the phpinfo tab, it does make sense in those random "did I/they compile that in" circumstances. ;-) Sorry for the rant.
Again, sorry for the long winded rant. Cheers everyone. Goodnight.
Sorry for the delay. My wife and I are in the process of buying a house, and some unexpected things have come up.
@bschussek Yes I mean this case =) Sorry for not being explicit, I need some coffee I think =)
Nevermind, I can see broken tests.. I'm on, sorry
@stof, ah sorry misunderstood, one of those days it seems :)
ok @stof sorry it said it seemed not to be possible, i thought it was possible but I am wrong.
Sorry for this. For some reason my PHP error reporting level was to low to catch this...
ah sorry, I looked at the patch too fast. Only the interface is moved
The other advantage is that under this methodology, there can be a UI experience on expiry, like "Sorry, your session expired due to being idle for 10 minutes".
Wasn't aware that github omits the trailing white line, sorry.
oops my mistake, sorry.
Sorry for nitpicking but what about:
Sorry no idea.
@vicb done, sorry about that commit: overlooked the fact that it was on the same branch...
It seems fine at first glance. I don't have time to look at it in detail right now sorry.
Sorry for the two previous pull requests :(
ah sorry, you talked only about the merge commit. Yeah it is normal. When reapplying your commits on top of master, the merge commit are not kept as you are reapplying the changes linearly on top of the other branch (and deleting the merge commit was the reason why @fabpot asked you to rebase instead of merging btw)
@kriswallsmith (Sorry about the confusing title) My concern is just that if you use Process then decide to "upgrade" to the ProcessBuilder, you suddenly have a change of behavior that might break stuff without you noticing. I just want to avoid this unexpected behavior.
Sorry non native speaker an a bit hard to explain, could you ping me in a couple of hours on IRC if this still doesn't make any sense.
Fixed the typo and changed the false to ture as reported in comments. I've also rebased. I'll see what I can do about config file change later today. Sorry for the delay, been too busy for the past week.
ah sorry, it was the profiler storage
Ok, looking at the patch, it is not the same than places where we used the naming "forward compatibility". Sorry
_Edit: Sorry, couldn't resist adding a private helper class again!_
@Tobion I'm sorry I did that, I'll edit the message asap. Seems no sleep in 26 hours can cause brain not to function as intended :)
Sorry, I messed up with the tickets. Didn't know a pull request opens a ticket.
Okay, finally I managed to upload the latest commit. If you got a bunch of notifications or so I'm sorry, but I had to revert some accidental changes in the commit :(
Sorry for the last PR, it was a fix to avoid fatal..
Sorry for the delay, was on vacations.
Sorry meant the ``ExtensionInterface``. I would like the ``getConfiguration`` method enforced. How would we tackle the FrameworkBundle? To retrieve it's configuration you need the ``ContainerBuilder``.
i am sorry .. but this is a bad decision ... mostly because you don't know what travis CI can do compared to our own jenkins. this needs to be discussed.
But for me as a contributor its a huge advantage already in its current form. This opposition is extremely frustrating because you are complaining about what amounts to a freaking single file called ".travis.yml" that provides real value to several frequent contributors. I am sorry but there is nothing to discuss here but to simply merge.
Sorry if this is so trivial it's annoying. I just fix 'em as I find 'em, and I keep commits small.
Sorry if I'm simply missing something or doing something silly.
Sorry for the inconvenience.
Sorry, I didn't think that we would be an issue since the Bundle "Best Practices" states to not include other bundles as dependencies.
<jmikola> correct, sorry
<jmikola> sorry, base_path***
Sorry for the delay, lifetime support is now implemented. What do you think about an AbstractProfilerStorageTest class to share some testing code between the different implementations (of cause in a separate PR)?
Ok sorry I missed the other PR. Sounds great :)
@stloyd sorry. I will rebase (squash) everything when I am finished.
I'm sorry I can't give you more help...
@fabpot Don't be sorry, I am about to fix the PHPDoc. I shall squash right after.
(squash failed sorry #2068)
damn sorry i have accidentally close the pull request ;(
sorry .. only realized this while shaving this morning ..
@lenar: ah, sorry about that. Then, can you provide a fix for all the other tests too? Thanks a lot.
Sorry, I can't reproduce it on Ubuntu and unless someone wants to sponsor me a Mac, there is not much I can do.
After more discussion on 761724ae57d07cee2368bee86a2f1fe22cf188fc - sorry you merged too fast for once ;)
@maoueh I just removed a couple of commits from the log. Seems like the tests you committed are now missing from the PR. Can you please send the tests once again? Sorry about that.
@helmer: 1) & 2) Sorry for that "bad language", but you get me wrong a bit. Tests was written for code in master (there was no problem to change them to work with your POV). 3) Same as before, you can adopt tests easily, but never mind. Maybe later we could cooperate better ;-)
added missing change from previous commit (sorry :()